#12895: Categories: adds support for SubcategoryMethods
-------------------------------------+--------------------------------------
Reporter: nthiery | Owner: nthiery
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.10
Component: categories | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Nicolas M. Thiéry | Merged in:
Dependencies: #11935, #12894 | Stopgaps:
-------------------------------------+--------------------------------------
Changes (by SimonKing):
* status: needs_review => positive_review
* reviewer: => Simon King
Old description:
> With this patch, a category can implement a nested class
> SubcategoryMethods that provides methods for all subcategories of this
> category (similar to ParentMethods that provides methods for all parents
> of all subcategories of this category).
>
> This is implemented by updating the class of each category C, at the end
> of its initialization, to insert C.subcategory_class as superclass (like
> what is done for Parents and Elements).
>
> This is a bit tricky, since the super_categories method needs to be
> called during the initialization.
>
> The patch is under finalization on http://combinat.sagemath.org/patches/
New description:
With this patch, a category can implement a nested class
SubcategoryMethods that provides methods for all subcategories of this
category (similar to ParentMethods that provides methods for all parents
of all subcategories of this category).
This is implemented by updating the class of each category C, at the end
of its initialization, to insert C.subcategory_class as superclass (like
what is done for Parents and Elements).
This is a bit tricky, since the super_categories method needs to be called
during the initialization.
The patch is under finalization on http://combinat.sagemath.org/patches/
__Apply__
* [attachment:trac_12895-subcategory-methods-nt.patch]
* [attachment:trac_12895-review.patch]
--
Comment:
Tests pass for me. The patchbot timed out, so I just kicked it. The patch
looks fine, except for the line continuation. Hence, I provided a review
patch.
Apply trac_12895-subcategory-methods-nt.patch trac_12895-review.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12895#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
