#13240: Give posets polynomials (order, characteristic, zeta, etc.)
------------------------------------------+---------------------------------
       Reporter:  csar                    |         Owner:  sage-combinat
           Type:  enhancement             |        Status:  new          
       Priority:  major                   |     Milestone:  sage-5.10    
      Component:  combinatorics           |    Resolution:               
       Keywords:  sd40, days45            |   Work issues:               
Report Upstream:  N/A                     |     Reviewers:               
        Authors:  Alex Csar, Kevin Dilks  |     Merged in:               
   Dependencies:                          |      Stopgaps:               
------------------------------------------+---------------------------------

Old description:

> Adding some of the polynomials from Stembridge's Posets package for Maple
> (see http://www.math.lsa.umich.edu/~jrs/software/posetshelp.html),
> namely:
>
>  * characteristic polynomial (done)
>  * zeta polynomial (done)
>  * flag f-polynomial (done)
>  * flag h-polynomial (done)
>  * f-polynomial (done)
>  * h-polynomial (done)
>  * order polynomial (done)
>  * chain polynomial (done)
>  * W-polynomial
>  * antichain polynomial
>
> apply:
> * [attachment:trac_1324O_first_step-fc.patch]
> * [attachment:trac_12340_poset_polynomials-csar.patch]

New description:

 Adding some of the polynomials from Stembridge's Posets package for Maple
 (see http://www.math.lsa.umich.edu/~jrs/software/posetshelp.html), namely:

  * characteristic polynomial (done)
  * zeta polynomial (done)
  * flag f-polynomial (done)
  * flag h-polynomial (done)
  * f-polynomial (done)
  * h-polynomial (done)
  * order polynomial (done)
  * chain polynomial (done)
  * W-polynomial
  * antichain polynomial

 apply:
 * [attachment:trac_1324O_first_step-fc.patch]
 * [attachment:trac_12340_poset_polynomials-csar.patch]
 * [attachment:trac_13240-review1-fc.patch]

--

Comment (by chapoton):

 ok, here is a short review patch of your code.

 I have removed trailing whitespaces that you had introduced, and made
 small changes to the code. I have also made sure that each method starts
 with a brief (one-line) description of what it does. Details are then
 given on other lines.

 I would prefer not to propose the use of another variable in the code, but
 rather give no option. The user will get a polynomial, that he can then
 evaluate on whatever he wants. I think this keeps the code cleaner and
 shorter.

 Combining patches is indeed easy, and can be done just once when
 everything is ready.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13240#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to