#14656: slight QA with flint definition
-----------------------------------+----------------------------------------
Reporter: fbissey | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.10
Component: cython | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: François Bissey | Merged in:
Dependencies: | Stopgaps:
-----------------------------------+----------------------------------------
Changes (by {'newvalue': u'Fran\xe7ois Bissey', 'oldvalue': ''}):
* status: needs_info => needs_review
* author: => François Bissey
Old description:
> When building sage in sage-on-gentoo we get the following QA report
> {{{
> * QA Notice: Package triggers severe warnings which indicate that it
> * may exhibit random runtime failures.
> * build/cythonized/sage/libs/flint/flint.c:664:3: warning: implicit
> declaration of function '_fmpz_cleanup_mpz_content' [-Wimplicit-function-
> declaration]
> }}}
> Which is quite correct as _fmpz_cleanup* functions are defined in
> flint/fmpz.h while the pxd file only includes flint/flint.h. It is
> possible that this file is included somehow, but it is cleaner just to
> add it.
>
> Apply to the sage library:
> * [attachment:trac_14656.patch]
New description:
When building sage in sage-on-gentoo we get the following QA report from
portage
{{{
* QA Notice: Package triggers severe warnings which indicate that it
* may exhibit random runtime failures.
* build/cythonized/sage/libs/flint/flint.c:664:3: warning: implicit
declaration of function '_fmpz_cleanup_mpz_content' [-Wimplicit-function-
declaration]
}}}
Which is quite correct as _fmpz_cleanup* functions are defined in
flint/fmpz.h while the pxd file only includes flint/flint.h. It is
possible that this file is included somehow, but it is cleaner just to add
it.
While I haven't noticed any failures being triggered by it, correcting the
cython declaration is the right thing to do.
Apply to the sage library:
* [attachment:trac_14656.patch]
--
Comment:
I should also note that a similar warning existed with flint 1.x and we
had a similar patch in sage-on-gentoo from sage-4.4.2 onwards. The QA at
the time suggested that it could cause memory leaks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14656#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
