#14673: turn crystalographic into crystallographic
-------------------------------------+--------------------------------------
Reporter: chapoton | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: spelling | Work issues: missing backward
compatibility alias in CartanType.samples
Report Upstream: N/A | Reviewers: Travis Scrimshaw,
Nicolas M. Thiéry
Authors: Frédéric Chapoton | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Changes (by nthiery):
* status: positive_review => needs_work
* reviewer: Travis Scrimshaw => Travis Scrimshaw, Nicolas M. Thiéry
* work_issues: => missing backward compatibility alias in
CartanType.samples
Comment:
Hi Frédéric!
Thanks for fixing this original typo of mine :-)
I went through the patch and am happy with it up to two details:
- Unless I missed it, there lacks a backward compatibility alias for
CartanType.samples(crystalographic=True).
- It would be good to add tests for the backward compatibility aliases.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14673#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
