#14690: Useless memory allocation in listing neighbors of a graph
--------------------------------------------+-------------------------------
Reporter: vdelecroix | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: graph theory | Resolution:
Keywords: sparse graph, allocation | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Vincent Delecroix | Merged in:
Dependencies: | Stopgaps:
--------------------------------------------+-------------------------------
Changes (by vdelecroix):
* status: new => needs_review
Old description:
> This patch exist because I am an idiot. I reviewed #14659 and did not
> notice that the creation of the list of neighbors actually allocates an
> array! So #14659 only solve half of the problem.
>
> The patch here remediate to the problem by adding an attribute `up` for
> the node of the binary tree (`SparseGraphBTNode`) that allows to do depth
> first search without storing anything.
New description:
This patch exist because I am an idiot. I reviewed #14659 and did not
notice that the creation of the list of neighbors actually allocates an
array! So #14659 only solves half of the problem.
The patch here remediates to the problem by adding an attribute `up` for
the node of the binary tree (`SparseGraphBTNode`) that allows to do depth
first search without storing anything.
--
Comment:
The patch is not yet finished but at least, with it applied, I can build
the `PetersonGraph` and `random_stress` does not complain ;-)
I would like some comments before going further.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14690#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
