#13084: Weierstrass form for toric elliptic curves
--------------------------------------+-------------------------------------
       Reporter:  vbraun              |         Owner:  AlexGhitza       
           Type:  enhancement         |        Status:  needs_review     
       Priority:  major               |     Milestone:  sage-5.10        
      Component:  algebraic geometry  |    Resolution:                   
       Keywords:                      |   Work issues:  coverage, doctest
Report Upstream:  N/A                 |     Reviewers:                   
        Authors:  Volker Braun        |     Merged in:                   
   Dependencies:  #12553, #13451      |      Stopgaps:                   
--------------------------------------+-------------------------------------

Comment (by dimpase):

 Attempting to look at the maths side. It's confusing that you start off
 talking about a **toric** elliptic curve, but then speak about "the
 elliptic curve". What is going on there?

 further nitpicks:

 {{{
 There are 16 reflexive polygons in 2-d.
 }}}
 Could you add a reference and change this to
 {{{
 There are 16 reflexive polygons in the plane.
 }}}

 And add an exact reference to the next statement.
 {{{
 Each defines a toric fano  variety, which (in 2-d) has a unique crepant
 resolution to a smooth
  toric surface.
 }}}
 Which should also be changed to
 {{{
 Each of them defines a toric Fano  variety...
 }}}

 Then,
 {{{
 It turns out that the anticanonical hypersurface equation...
 }}}
 Reference?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13084#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to