#14701: Delsarte's formula for counting the number of subgroups of an abelian
p-group of a given type
-----------------------------------------------------+----------------------
Reporter: amri | Owner:
sage-combinat
Type: enhancement | Status:
needs_review
Priority: minor | Milestone:
sage-5.11
Component: combinatorics | Resolution:
Keywords: q_analogues, finite-abelian-group | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Amritanshu Prasad | Merged in:
Dependencies: | Stopgaps:
-----------------------------------------------------+----------------------
Comment (by tscrim):
Hey Amri,
Here's a review patch which does the following:
- Uses `**` instead of `^` since in python (which all `.py` files get
interpreted as) the latter means bitwise-xor.
- Makes some simplifications to your code by using the `prod` function
instead of `reduce`.
- Expands on the docstrings and changes them around for some formatting
and default latex macros for sage.
If you're happy with my changes, you can go ahead and set this to positive
review. Feel free to ask me any questions if you have any.
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14701#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
