#5664: [with patch, needs review] Bugs in PermutationGroup_subgroup.__cmp__
--------------------------+-------------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: defect | Status: new
Priority: critical | Milestone: sage-4.0
Component: group_theory | Keywords: comparison subgroup
--------------------------+-------------------------------------------------
Comment(by SimonKing):
Replying to [comment:21 SimonKing]:
> The new patch (relative to sage-3.4.1.rc3) now relies on gap's
{{{IsSubgroup}}}.
...
> It seems to me that {{{IsSubgroup}}} is much faster than
{{{is_subgroup}}, hence I suggest that the latter should be rewritten. But
this will be a different ticket.
Done, the ticket is #5844 -- [with patch, needs review], hint hint...
To my surprise, after applying #5844, {{{is_subgroup}}} seems ''faster''
then {{{IsSubgroup}}}. Hence, as soon as #5844 is merged, I suggest to
change {{{IsSubgroup}}} into {{{is_subgroup}}} and avoid the call to Gap.
I do not change the tag into [with patch, needs work], since the present
patch fixes a bug and does ''not'' depend on #5844. The change after
inclusion of #5844 is only about performance, and should probably be on a
different ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5664#comment:22>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
