#14489: _S_class_group_and_units is mathematically incorrect
---------------------------------+------------------------------------------
Reporter: robharron | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.11
Component: number fields | Resolution:
Keywords: S-class group | Work issues:
Report Upstream: N/A | Reviewers: Peter Bruin
Authors: Robert Harron | Merged in:
Dependencies: | Stopgaps:
---------------------------------+------------------------------------------
Comment (by robharron):
Thanks for reviewing this, Peter. In instances where sage is silently
returning a mathematically incorrect answer, I try to create a minimal
patch that fixes the problem to speed up the review process and get the
fix in quickly. So, I'd suggest that since you think the patch I've
written works properly, then you should accept this ticket and open a new
ticket (which would be an enhancement ticket rather than a defect ticket)
to clean up the code. My rationale is that the patch I wrote only changed
a couple dozen lines of code and is fairly simple and yet has taken almost
2 months to be reviewed, so who knows how long this new patch would take
to review? Makes sense?
(Also, note that the long sentences in the docstrings and the term
"principal generator" were already present before my patch. My philosophy
of minimal changes made me leave them in.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14489#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
