#12940: Combinatorial implementation of the affine symmetric group
---------------------------------------------------------+------------------
Reporter: sdenton | Owner: tom
denton
Type: enhancement | Status:
needs_review
Priority: minor | Milestone:
sage-5.11
Component: combinatorics | Resolution:
Keywords: affine, combinatorics, days38, days49 | Work issues:
Report Upstream: N/A | Reviewers:
Chris Berg, Anne Schilling
Authors: tom denton | Merged in:
Dependencies: #14673, #8392 | Stopgaps:
---------------------------------------------------------+------------------
Comment (by aschilling):
Hi Tom,
Here are some more comments about your patch:
- is_i_grassmannian(i=0, side='right') needs a description of the input
(like the i).
- Please explain the input of to_weyl_group_element(W=None)
- has_right_descent has a description of an option which is not there
('right' or 'left').
Same for has_left_descent.
- Everywhere in the file you seem to use OPTIONS:. This should be replaced
by or combined with INPUT. Also, as far as I know the syntax is
{{{
- ``variable`` -- description of what it does.
}}}
Tom, could you make the above changes? Also, I left a review patch called
trac_12940-review-as.patch on the sage-combinat queue. Please fold it into
the rebased patch on the sage-combinat queue.
Thanks!
Anne
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12940#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
