#13272: clean up the factor() docstring/interface for univariate polynomials
---------------------------------+------------------------------------------
       Reporter:  saraedum       |         Owner:  mvngu      
           Type:  task           |        Status:  needs_work 
       Priority:  trivial        |     Milestone:  sage-5.11  
      Component:  documentation  |    Resolution:             
       Keywords:  beginner       |   Work issues:             
Report Upstream:  N/A            |     Reviewers:  Peter Bruin
        Authors:  Julian Rueth   |     Merged in:             
   Dependencies:                 |      Stopgaps:             
---------------------------------+------------------------------------------
Changes (by pbruin):

  * status:  needs_review => needs_work


Comment:

 Unfortunately the whitespace matters a lot:

 {{{
 sage: hg_sage.qapplied()
 cd "/home/staff/pbruin/src/sage-5.10.rc2/devel/sage" && sage --hg qapplied
 trac_13272_proof.patch
 sage: hg_sage.qpush()
 cd "/home/staff/pbruin/src/sage-5.10.rc2/devel/sage" && sage --hg qpush
 applying trac_13272_docstring.patch
 patching file sage/rings/polynomial/polynomial_element.pyx
 Hunk #1 FAILED at 2464
 Hunk #2 FAILED at 2504
 Hunk #3 FAILED at 2518
 Hunk #5 FAILED at 2577
 Hunk #6 FAILED at 2598
 Hunk #8 FAILED at 2691
 Hunk #9 FAILED at 2719
 Hunk #10 FAILED at 2741
 Hunk #12 FAILED at 2809
 Hunk #13 FAILED at 2933
 Hunk #14 FAILED at 3020
 11 out of 14 hunks FAILED -- saving rejects to file
 sage/rings/polynomial/polynomial_element.pyx.rej
 patch failed, unable to continue (try -v)
 patch failed, rejects left in working dir
 errors during apply, please fix and refresh trac_13272_docstring.patch
 }}}

 In the meantime I did manage to rebase the first version of your patch,
 but even apart from whitespace the resulting patch has several differences
 with your new patch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13272#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to