#14794: DiGraph constructor doc describes `boundary` option wrong
---------------------------------------------------+------------------------
Reporter: mguaypaq | Owner: mguaypaq
Type: defect | Status:
needs_review
Priority: major | Milestone: sage-5.12
Component: graph theory | Resolution:
Keywords: graph, digraph, mutable default | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Mathieu Guay-Paquet | Merged in:
Dependencies: | Stopgaps:
---------------------------------------------------+------------------------
Comment (by mguaypaq):
I looked up the old ticket where this happened to me, and it was #10304.
Apparently the default argument is from http://effbot.org/zone/default-
values.htm, which I've seen lots of times in various forums at this point.
I just started a thread about this on sage-devel.
As for accepting `None` even though it's not the documented way anymore,
it's just because this is a standard idiom for default values. Note that
the changed documentation doesn't forbid it, just doesn't encourage it.
The important point is that `self._boundary` is not set to `None` anymore.
Is this good enough for a positive review?
Cheers,
Mathieu
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14794#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
