#11407: Add normalization to clonable lists
----------------------------------------------------------+-----------------
Reporter: hivert | Owner:
hivert
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-5.11
Component: combinatorics | Resolution:
Keywords: clone normalization Cernay2012, days49 | Work issues:
Report Upstream: N/A | Reviewers:
Travis Scrimshaw
Authors: Florent Hivert | Merged in:
Dependencies: #11308 | Stopgaps:
----------------------------------------------------------+-----------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Old description:
> The patch adds a new support class in {{{list_clone.pyx}}} for lists with
> a normalization methods. The normalization method is called both after
> creation and clone/modification. This will be needed for rooted trees.
>
> I also take the opportunity of cleaning up the bad usage of {{{assert}}}
> in
> the examples and replaced them by {{{if ... : raise ValueError}}}.
>
> '''Apply''' [attachment:trac_11407-list_clone_improve-fh.patch]
New description:
The patch adds a new support class in {{{list_clone.pyx}}} for lists with
a normalization methods. The normalization method is called both after
creation and clone/modification. This will be needed for rooted trees.
I also take the opportunity of cleaning up the bad usage of {{{assert}}}
in
the examples and replaced them by {{{if ... : raise ValueError}}}.
'''Apply'''
* [attachment:trac_11407-list_clone_improve-fh.patch]
* [attachment:trac_11407-review-ts.patch]
--
Comment:
Hey Florent,
Looks good minus the one missed change in the review patch I've uploaded.
After you give it a quick check, and you set this to positive review.
Best,[[BR]]
Travis
For patchbot:
Apply: trac_11407-list_clone_improve-fh.patch trac_11407-review-ts.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11407#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
