#14752: typo causes failure in nonsplit Cartan image for elliptic curve Galois
representation
-----------------------------------------+----------------------------------
       Reporter:  cremona                |         Owner:  cremona        
           Type:  defect                 |        Status:  positive_review
       Priority:  minor                  |     Milestone:  sage-5.11      
      Component:  elliptic curves        |    Resolution:                 
       Keywords:  galois representation  |   Work issues:                 
Report Upstream:  N/A                    |     Reviewers:  Chris Wuthrich 
        Authors:  John Cremona           |     Merged in:                 
   Dependencies:                         |      Stopgaps:                 
-----------------------------------------+----------------------------------
Changes (by wuthrich):

  * status:  needs_review => positive_review
  * reviewer:  => Chris Wuthrich


Old description:

> In 5.10.rc2 (i.e. even after applying the patch at #14577) this happens:
> {{{
> EllipticCurve([0, 0, 0,
> -1129345880,-86028258620304]).galois_representation().image_type(11)
> ...
> NameError: global name 'nonsplit_str' is not defined
> }}}
>
> Solution: fix typos ("nonsplit_str" --> "non_split_str") in two places.

New description:

 In 5.10.rc2 (i.e. even after applying the patch at #14577) this happens:
 {{{
 EllipticCurve([0, 0, 0,
 -1129345880,-86028258620304]).galois_representation().image_type(11)
 ...
 NameError: global name 'nonsplit_str' is not defined
 }}}

 Solution: fix typos ("nonsplit_str" --> "non_split_str") in two places.

 Apply: The patch below.

--

Comment:

 All tests pass. Thanks for fixing my typos.

 (To be precise, I get one error in sage/modular/modform/find_generators.py
 when testing with --long. But I am certain that it is not caused by this
 ticket.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14752#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to