#14808: Permutation([1,2,3,5,4]).recoils_composition() returns [5] instead of 
[4,
1], and similar bugs
--------------------------------------------------+-------------------------
       Reporter:  darij                           |         Owner:  tbd         
    
           Type:  defect                          |        Status:  
needs_review    
       Priority:  major                           |     Milestone:  sage-5.12   
    
      Component:  combinatorics                   |    Resolution:              
    
       Keywords:  combinat, permutations, days49  |   Work issues:              
    
Report Upstream:  N/A                             |     Reviewers:  Travis 
Scrimshaw
        Authors:  Darij Grinberg                  |     Merged in:              
    
   Dependencies:                                  |      Stopgaps:              
    
--------------------------------------------------+-------------------------

Comment (by darij):

 Hi Travis,

 thank you; good that you caught the "returns"es (I still haven't totally
 internalized docstring conventions).

 1. Only two things I want you to look at. In the docstring of {{{def
 PermutationOptions}}}, I added periods in
 {{{
 -    display: 'list' - the permutations are displayed in list notation
 -    'cycle' - the permutations are displayed in cycle notation
 }}}
 so as to delimit the different lines (otherwise, due to only single rather
 than double linebreak being used, they would be undelimited in the HTML
 output). You, however, have removed this docstring completely. Was it
 obsolete?

 2. The docstring of {{{def number_of_inversions}}}: It should say "a pair
 of elements `(i,j)`", not "a pair of elements `(p_i,p_j)`".

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14808#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to