#14498: trees and binary trees
----------------------------------------------+-----------------------------
Reporter: elixyre | Owner: sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Keywords: trees, binary trees, latex | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jean-Baptiste Priez | Merged in:
Dependencies: #8703 | Stopgaps:
----------------------------------------------+-----------------------------
Comment (by VivianePons):
Hi,
I cannot apply your patch, maybe it's conflicting with #14731 and #14784
which have already been positively reviewed are already or will be merged
in sage 5.11. Also, we actually wrote twice the same things, I have two
methods "to_132_avoiding_permutation" and "to_312_avoiding_permutation"
which are somehow similar to your "canonical_permutation". I think we
should keep my name which is clearer. But for these methods, I wrote a
"_postfix_word" method which is similar to your "post_order_traversal"
thing (but I think yours is better and with better documentation). But my
patch has already been merged, so you should write yours on top of mine
and just replace my methods by yours when they're better.
About names, I think "sylvestrohedron_greater" is not a good name, we
should say "Tamari_greater", because it's more commonly used.
Do you want to come to Marne-la-vallee so that we can work on the merge of
your patch with mine? I'll be there Thursday, Friday and Monday. Then
again at the end of July. Please tell me
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14498#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
