#5665: [with patch, positive review] Bug in ShrinkingGeneratorCipher
------------------------------------------------+---------------------------
Reporter: sbulygin | Owner: kohel
Type: defect | Status: reopened
Priority: minor | Milestone: sage-3.4.2
Component: cryptography | Resolution:
Keywords: stream cipher, shrinking generator |
------------------------------------------------+---------------------------
Comment(by mabshoff):
Replying to [comment:6 kohel]:
> Maybe I shouldn't have clicked on 'fixed' (although the two changes fix
the problem). This indeed told me that the ticket would then be set to
closed.
Well, a fixed ticket no longer appears on the default view and just
because someone does give a ticket a positive review does not mean it will
be merged since any doctest failure will bounce the ticket right back.
Closing tickets once a patch has been merged is the only sane way to keep
track of which fix was merged in Sage.
> Creating a patch seems overkill, since only two characters have changed
(1->2 and K->D).
No, creating a patch is essential for credit, etc.
> However, you are correct about the doctests; it looks like the
ciphertext in line 229 will have to be substituted with the new output.
It is essential to run doctests and to add additional doctests in case the
problem was not previously covered by a doctest. This does not seem to be
the case here, but I will find out in the morning.
> Cheers,
>
> David
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5665#comment:7>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
