#12250: Implementation of weak k-tableaux
-------------------------------------------------+--------------------------
Reporter: aschilling | Owner:
sage-combinat
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution:
Keywords: tableaux, days49 | Work issues:
Report Upstream: N/A | Reviewers: Mike
Zabrocki, Anne Schilling
Authors: Anne Schilling, Mike Zabrocki | Merged in:
Dependencies: #14519 | Stopgaps:
-------------------------------------------------+--------------------------
Comment (by tscrim):
Hey Anne and Mike,
Thank you both for your work on this. However there are a few things I've
noticed while glancing over the patch:
- The inner bullet list on the `INPUT:` block for `WeakTableau` has one
too many spaces, so it is overly indented. It needs to line up as follows:
{{{
- item 1
- inner item a
- inner item b
- item 2
}}}
- `k_charge_I()` and `k_charge_J()` have the same docstring. In fact, it
might be worthwhile to actually describe the algorithm.
- I think it is worthwhile to have one abstract base class for all
`WeakTableau` elements which has it's abstract methods defined. For
example, you can also consolidate all of the more detailed explanations of
the methods in there and link to them in their concrete classes. In
particular, it because an easier/more straightforward to check to see if
it's a `WeakTableau` and allow you an easy way to compare `__eq__` between
different representations of a weak tableau.
- In the same vein, could we make it so that we can convert between
different representations with parents? I.e. I'd like to do the following:
{{{
sage: T = WeakTableaux(3, [5,2,1], [1,1,1,1,1,1])
sage: T2 = WeakTableaux(3, [3,2,1], [1,1,1,1,1,1],
representation='bounded')
sage: T2(T[0])
}}}
- Could we have a method like `T.representation('bounded')` which returns
the corresponding parent using a different representation. Same on the
elements (which of course would call the respective `to_*` method, but it
would make it consistent IMO)?
- I don't see an easy way to go to a factorized permutation from the other
2 representations. Right now it seems like I have to call
{{{
WeakTableau_factorized_permutation.from_core_tableau().
}}}
- I think the `from_*` (and quite possibly the `to_*`) methods maybe
should be available in the parents rather than as classmethods for the
element classes.
- The `.. SEEALSO::` block in `k_charge()` is not formatting correctly, so
it doesn't link the methods.
- Could you use the {{{:arxiv:`1234.5678`}}} autolink?
- Remove ``self`` as an input (ex. in `list_of_standard_cells()`)
Ack, that ended up being a longer list than I expected...
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12250#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
