#10963: More functorial constructions
-------------------------------------------------------------------------+--
       Reporter:  nthiery                                                |      
   Owner:  stumpc5                                  
           Type:  enhancement                                            |      
  Status:  needs_review                             
       Priority:  major                                                  |     
Milestone:                                           
      Component:  categories                                             |    
Resolution:                                           
       Keywords:                                                         |   
Work issues:  Finish merging some changes in the primer
Report Upstream:  N/A                                                    |     
Reviewers:  Simon King                               
        Authors:  Nicolas M. ThiƩry                                      |     
Merged in:                                           
   Dependencies:  #11224, #8327, #10193, #12895, #14516, #14722, #13589  |      
Stopgaps:                                           
-------------------------------------------------------------------------+--

Comment (by SimonKing):

 Here are the failures in detail:
 The first is noise:
 {{{
 sage -t devel/sage/sage/geometry/polyhedron/plot.py
     [178 tests, 5.55 s]
 ----------------------------------------------------------------------
 All tests passed!
 ----------------------------------------------------------------------
 Total time for all tests: 5.8 seconds
     cpu time: 4.3 seconds
     cumulative wall time: 5.6 seconds
 }}}

 The second:
 {{{
 sage -t devel/sage/sage/categories/category.py
 **********************************************************************
 File "devel/sage/sage/categories/category.py", line 1940, in
 sage.categories.category.Category.join
 Failed example:
     type(TCF)
 Expected:
     <class
 
'sage.categories.category_with_axiom.TestObjects.Commutative.Facade_with_category'>
 Got:
     <class
 'sage.categories.category_with_axiom.Commutative.Facade_with_category'>
 **********************************************************************
 File "devel/sage/sage/categories/category.py", line 1950, in
 sage.categories.category.Category.join
 Failed example:
     type(TCF)
 Expected:
     <class
 
'sage.categories.category_with_axiom.TestObjects.Commutative.FiniteDimensional_with_category'>
 Got:
     <class
 
'sage.categories.category_with_axiom.Commutative.FiniteDimensional_with_category'>
 **********************************************************************
 File "devel/sage/sage/categories/category.py", line 1963, in
 sage.categories.category.Category.join
 Failed example:
     type(TUCF)
 Expected:
     <class
 
'sage.categories.category_with_axiom.TestObjects.FiniteDimensional.Unital.Commutative_with_category'>
 Got:
     <class
 'sage.categories.category_with_axiom.Unital.Commutative_with_category'>
 **********************************************************************
 1 item had failures:
    3 of  47 in sage.categories.category.Category.join
     [388 tests, 3 failures, 6.89 s]
 ----------------------------------------------------------------------
 sage -t devel/sage/sage/categories/category.py  # 3 doctests failed
 ----------------------------------------------------------------------
 Total time for all tests: 7.3 seconds
     cpu time: 6.8 seconds
     cumulative wall time: 6.9 seconds
 }}}

 The third needs to be taken care of only if #12630 finally gets a review.

 The last one:
 {{{
 sage -t devel/sage/sage/categories/category_with_axiom.py
 **********************************************************************
 File "devel/sage/sage/categories/category_with_axiom.py", line 755, in
 sage.categories.category_with_axiom.CategoryWithAxiom.__reduce__
 Failed example:
     C.__class__
 Expected:
     <class
 
'sage.categories.distributive_magmas_and_additive_magmas.DistributiveMagmasAndAdditiveMagmas.AdditiveAssociative.AdditiveCommutative_with_category'>
 Got:
     <class
 
'sage.categories.distributive_magmas_and_additive_magmas.AdditiveAssociative.AdditiveCommutative_with_category'>
 **********************************************************************
 1 item had failures:
    1 of   8 in
 sage.categories.category_with_axiom.CategoryWithAxiom.__reduce__
     [179 tests, 1 failure, 0.25 s]
 }}}

 So, nothing dramatic.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10963#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to