#14772: Remove CombinatorialClass from Permutations
------------------------------+--------------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: | Status: positive_review
enhancement | Milestone: sage-5.11
Priority: major | Resolution:
Component: | Merged in:
combinatorics | Reviewers: Mike Hansen, Darij Grinberg
Keywords: days49 | Work issues:
Authors: Travis | Dependencies: #8386 #14519 #14808
Scrimshaw |
Report Upstream: N/A |
Branch: |
Stopgaps: |
------------------------------+--------------------------------------------
Comment (by darij):
Nice! Thanks for the tweaks.
> When doing something like `Permutation([1,2,3])`, what happens is first
`__classcall_private__()` is called which should process the information
and return the correct object (it's super function will call the class's
`__init__()` if called). So in the above example, it creates puts the
permutation in the correct parent class. For `Permutations`, it returns
the correct parent object based upon the input.
Okay. What is the difference to `__classcall__()`?
> I can't change this back because I have to make it use the correct class
(because there is no longer a `Permutation_class`). I'll review #14883
however.
I'm surprised by the fact that #14883 still applies; since it does, of
course, it's better to just leave it separated.
--
Ticket URL: <http://trac.sagemath.org/ticket/14772#comment:50>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
