#5844: [with patch, positive review] Improvement of
PermutationGroup_generic.has_element() and is_subgroup
--------------------------+-------------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: enhancement | Status: new
Priority: minor | Milestone: sage-3.4.2
Component: group_theory | Keywords: PermutationGroup has_element
is_subgroup
--------------------------+-------------------------------------------------
Comment(by mabshoff):
Replying to [comment:8 wdj]:
Hi David,
> Applies to 3.4.1.rc3 and seems to pass all tests (my copy has massive
failures both due to the gap interface and the maxima interface, but these
seem unrelated to these patches).
Why don't you doctest on sage.math? You can do it in parallel, there is
*always* a binary and it works unless otherwise noted in the release
notes.
> Postive. Review. Thanks Simon and sorry for the delay - it's the end of
the semester here...
Do not give positive reviews to any ticket that does not pass doctests,
even if you assume it is unrelated to failures you see. The whole point of
doctesting is to also verify that no side effects cause any trouble and
given that you see GAP failures I cannot honestly see how this patch could
not potentially cause trouble here.
I am doctesting this patch against my current merge tree to see if there
are any issues.
Cheers,
Michael
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5844#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
