#14234: Restructuring Diagram/Partition Algebras to match category structure
-------------------------------------------------+-------------------------
       Reporter:  ghseeli                        |         Owner:
           Type:  enhancement                    |  AlexGhitza
       Priority:  minor                          |        Status:
      Component:  algebra                        |  needs_review
       Keywords:  Partition algebra, diagram     |     Milestone:
  algebra, days38, days40                        |  sage-5.11
        Authors:  Stephen Doty, Aaron Lauve,     |    Resolution:
  George H. Seelinger                            |     Merged in:
Report Upstream:  N/A                            |     Reviewers:  Travis
         Branch:                                 |  Scrimshaw
       Stopgaps:                                 |   Work issues:
                                                 |  Dependencies:
-------------------------------------------------+-------------------------
Changes (by {'newvalue': u'Stephen Doty, Aaron Lauve, George H. Seelinger', 
'oldvalue': u'ghseeli, s.r.doty, alauve'}):

 * author:  ghseeli, s.r.doty, alauve => Stephen Doty, Aaron Lauve, George
     H. Seelinger


Comment:

 Okay, here's my review patch. I changed `IdealAlgebra` to
 `IdealPartitionAlgebra`, which is (much) better but I'm not perfectly
 happy with. If you can think of a better name, then I'll change it. I've
 also reorganized the class structure to better use base classes and
 implemented a coercion up to the ambient space for the subalgebras. After
 that it's mostly docstring/doctest additions and corrections.

 If you agree with my changes (and can't think of a better name), you can
 go ahead and set this to positive review. Thanks.

--
Ticket URL: <http://trac.sagemath.org/ticket/14234#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to