#14957: Square-free decomposition and any_root for polynomials
-------------------------------------+-------------------------------------
       Reporter:  pbruin             |         Owner:
           Type:  enhancement        |        Status:  positive_review
       Priority:  major              |     Milestone:  sage-5.12
      Component:  algebra            |    Resolution:
       Keywords:  polynomial sd51    |     Merged in:
        Authors:  David Roe, Jean-   |     Reviewers:  Jean-Pierre Flori,
  Pierre Flori, Peter Bruin          |  Peter Bruin
Report Upstream:  N/A                |   Work issues:
         Branch:                     |  Dependencies:
       Stopgaps:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'David Roe, Jean-Pierre Flori, Peter Bruin', 
'oldvalue': u'David Roe, Jean-Pierre Flori'}):

 * status:  needs_review => positive_review
 * reviewer:   => Jean-Pierre Flori, Peter Bruin
 * author:  David Roe, Jean-Pierre Flori => David Roe, Jean-Pierre Flori,
     Peter Bruin


Comment:

 I already reviewed David's code and did not really touch this part apart
 for a few fixes.

 I also agree with Peter's changes.

 Everything seems to work fine, but note that if I test this on top of
 #14888, then two doctests fail.
 I think we should make this one depend on #14888, does anyone disagree?
 If we go this way, this should get positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/14957#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to