#13101: enumerate_totallyreal_fields bug fix
----------------------------------------------+----------------------------
Reporter: jvoight | Owner:
Type: defect | davidloeffler
Priority: major | Status: needs_work
Component: number fields | Milestone: sage-5.12
Keywords: sd51 | Resolution:
Authors: Robert Harron, John Voight | Merged in:
Report Upstream: N/A | Reviewers: Alex Ghitza
Branch: | Work issues:
Stopgaps: | Dependencies:
----------------------------------------------+----------------------------
Comment (by robharron):
Yeah, I added that doctest: every time there is a bug fix, there has to be
a corresponding doctest added to show that the bug has been fixed. Since
I'm not really familiar with the workings of this part of sage, I simply
took the snippet of code from the bug report and added it as a doctest.
What Jeroen is asking is whether there is a shorter test that would fail
before this bug fix but pass afterwards, thus showing things were fixed.
Can you cook one of those up?
Replying to [comment:8 jvoight]:
> Did someone add
>
> {{{
> sage: enumerate_totallyreal_fields_all(8, 10^8)
> }}}
>
> to the doctest? This was just an example that caused the stupid bug and
I don't think it was ever intended for a doctest. But then we also
probably want to keep it for future testing purposes, right?
>
> There is an easy doctest in there already
>
> {{{
> enumerate_totallyreal_fields_rel(F, 2, 2000)
> }}}
>
> and for general purposes of testing, this should be enough, IMHO. JV
--
Ticket URL: <http://trac.sagemath.org/ticket/13101#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
