#5898: [with patch, needs review] Plot Field doc
----------------------+-----------------------------------------------------
Reporter: kcrisman | Owner: was
Type: defect | Status: new
Priority: minor | Milestone: sage-3.4.2
Component: graphics | Keywords:
----------------------+-----------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
That patch {{{plot_field-patch.patch}}} applies OK against Sage
3.4.2.alpha0. All doctests passed with options {{{-t -long}}}, and the
coverage for {{{sage/plot/plot_field.py}}} is indeed 100% as claimed.
However, when I ran the coverage on that file, I received this
{{{
[mv...@sage sage-3.4.2.alpha0]$ ./sage -coverage devel/sage-
exp/sage/plot/plot_field.py
----------------------------------------------------------------------
devel/sage-exp/sage/plot/plot_field.py
ERROR: Please define a s == loads(dumps(s)) doctest.
SCORE devel/sage-exp/sage/plot/plot_field.py: 100% (7 of 7)
Possibly wrong (function name doesn't occur in doctests):
* _repr_(self):
* _render_on_subplot(self, subplot):
}}}
Notice the line
{{{
ERROR: Please define a s == loads(dumps(s)) doctest.
}}}
Apart from that, there are some minor typos. These are trivial to fix. The
reviewer patch {{{trac_5898-referee.patch}}} should take care of them.
Basically, it adds a test to dump and load a plot so that the above error
line should be gone when running coverage on {{{sage/plot/plot_field.py
}}}. So {{{plot_field-patch.patch}}} gets a positive review; only
{{{trac_5898-referee.patch}}} needs to be reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5898#comment:2>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
