#14963: Add functionality for S-units to UnitGroup
-------------------------------------------------+-------------------------
Reporter: cremona | Owner: cremona
Type: enhancement | Status:
Priority: major | needs_review
Component: number fields | Milestone:
Keywords: sd51, units, S-units, number | sage-5.12
fields | Resolution:
Authors: John Cremona | Merged in:
Report Upstream: N/A | Reviewers: Peter
Branch: | Bruin
Stopgaps: | Work issues:
| Dependencies: #14489,
| #14746
-------------------------------------------------+-------------------------
Changes (by pbruin):
* cc: pbruin (removed)
* reviewer: => Peter Bruin
Comment:
This looks good to me. I like the fact that S-units are now neatly
integrated into the `UnitGroup` class and did not require a separate
class.
Did you write this patch on a 32-bit system? I am getting two doctest
failures in my 64-bit Sage 5.11.rc0, which are almost certainly due to
32/64-bit differences in PARI (this also occurred in the two dependencies
of this ticket).
Apart from that, I can only suggest a few cosmetic changes (mostly
trailing whitespace). I will upload a reviewer patch and am planning to
give this a positive review once doctesting has finished.
--
Ticket URL: <http://trac.sagemath.org/ticket/14963#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
