#5880: [with patch; needs work] notebook -- greatly reduce the number of actions
that trigger taking a snapshot
----------------------+-----------------------------------------------------
Reporter: was | Owner: boothby
Type: defect | Status: new
Priority: major | Milestone: sage-3.4.2
Component: notebook | Keywords:
----------------------+-----------------------------------------------------
Comment(by rbeezer):
This patch removes several unnecessary occurrences of
{{{save_snapshot()}}} in the notebook. The most significant is that
autosave is disabled by inserting a {{{return}}}, so an explicit save is
required.
As written the patch breaks several doctests. It seems that in testing,
new worksheets are created, but there is no save done under the change in
the patch to the {{{__init__}}} method for a worksheet. For example in
the doctest for {{{__getstate___}}} the {{{_Worksheet__saved_by_info}}}
key is not present post-patch, causing the doctest to fail. One fix is
to make an explicit call to {{{save_snapshot()}}} after each new creation
of a test worksheet in a doctest. Or, in the reviewer patch, I have just
restored the {{{save_snapshot()}}} call to the {{{__init__}}} method for a
worksheet since it (a) seems like not such a bad idea, and (b) isn't
really a big contributor to the problem of excessive snapshots.
The change to {{{SendWorksheetToStop}}} in {{{twist.py}}} eliminates a
save as part of the "stop" so the docstring needs an adjustment. That
minor change is in the reviewer patch as well.
This is a positive review, subject to fixing doctests, either with
approval of the reviewer patch, or by further changes to problematic
docstrings.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5880#comment:3>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
