#12188: Bug in is_smooth for curves over CC
--------------------------------------+-----------------------------
Reporter: johanbosman | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.11
Component: algebraic geometry | Resolution:
Keywords: singular | Merged in:
Authors: Peter Bruin | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Dependencies:
Stopgaps: |
--------------------------------------+-----------------------------
Comment (by pbruin):
Replying to [comment:2 burcin]:
> I'm not sure if this is actually supposed to work in Sage right now.
Multivariate polynomial rings over `CC` use a generic implementation. The
error message should just say "First parameter's ring must be multivariate
polynomial ring via libsingular." This is not entirely clear, but at least
it is a less scary message than "singular_ring_delete(ring*) called with
NULL pointer."
With the patch, the example in the ticket description gives the right
answer (`is_smooth() -> True`) and no error.
> Here is a shorter segment to reproduce the problem: [...]
Here the correct `TypeError` message is displayed.
> It seems that `GroebnerStrategy.__cinit__()` (why `__cinit__` and not
`__init__`?)
It would be cleaner to separate the initialisation of Python and C
attributes into `__init__` and `__cinit__`. I tried changing `__cinit__`
to `__init__` and it did not make any difference.
> already has a doctest for this case. I don't see why the error message
is not caught by the doctesting framework. Are these cython errors printed
to `stderr` now?
This is indeed surprising.
> In any case, `GroebnerStrategy.__cinit__()` raises an error on line 99
of `sage/libs/singular/groebner_strategy.pyx`. I thought the
`__dealloc__()` method is not called if there is an error during
`__init__()`. Any ideas what is going wrong here?
Apparently `__dealloc__` ''is'' called; I didn't check the Cython
documentation.
--
Ticket URL: <http://trac.sagemath.org/ticket/12188#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
