#14969: Longest common subword
---------------------------------+-----------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers: Hugh Thomas
Report Upstream: N/A | Work issues:
Branch: | Dependencies:
Stopgaps: |
---------------------------------+-----------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
Helloooooooooooo !!
> Review patch uploaded. I don't think it will be controversial.
+1
> I removed one line of code which did nothing useful. (Please confirm.)
+1
> The commit message on the original patch should be, um, more
descriptive.
Right. Fixed.
> Other than that, I am ready to give it a positive review if you approve
my changes.
+1
> What a nice algorithm!
>
> The same approach could be used to find all that longest common
subwords. Do you think that would be useful? To me it seems at least as
natural.
Hmmmm. Well, the same algorithm with the same complexity can return the
number of longest common subwords too. In order to return all longest
subwords, though, one would have to keep track of all `l[i,j]`, and not
just `l[i,j]` and `l[i-1,j]`.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/14969#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
