#15026: Fix wrong except clauses
----------------------------------+--------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-5.12
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: Punarbasu Purkayastha
Report Upstream: N/A | Work issues:
Branch: | Dependencies:
Stopgaps: |
----------------------------------+--------------------------------------
Changes (by ppurka):
* status: needs_review => positive_review
* reviewer: => Punarbasu Purkayastha
Comment:
It is true that the code is functionally unchanged. But the way it is
written makes me think that the original author intended to catch both
`AttributeError` and `TypeError`. This clearly won't be caught in doctests
since it has probably never been doctested when, if at all, `TypeError` is
caught.
Anyway, it has been over two years since the code is present and no one
has complained. So, a positive review then. :)
--
Ticket URL: <http://trac.sagemath.org/ticket/15026#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
