#12338: fix the frobby optional tests to be marked "# optional - frobby" (very
easy!)
----------------------------+----------------------------------------------
Reporter: was | Owner: was
Type: | Status: closed
enhancement | Milestone: sage-duplicate/invalid/wontfix
Priority: minor | Resolution: duplicate
Component: | Merged in:
interfaces | Reviewers: Miguel Marco
Keywords: | Work issues:
Authors: | Commit:
Report Upstream: N/A | Stopgaps:
Branch: |
Dependencies: |
----------------------------+----------------------------------------------
Changes (by jdemeyer):
* status: positive_review => closed
* resolution: => duplicate
Old description:
> These tests should all be marked {{{# optional - frobby}}}, but none of
> them are:
>
> {{{
> sage: search_src('frobby')
> misc/citation.pyx:26:systems['Frobby'] = ['sage.interfaces.frobby']
> interfaces/frobby.py:18: The official source for Frobby is
> \url{http://www.broune.com/frobby},
> interfaces/frobby.py:42: sage: frobby("analyze",
> input="vars x,y,z;[x^2,x*y];", #optional
> interfaces/frobby.py:46: We get an exception if frobby reports
> an error.
> interfaces/frobby.py:47: sage: frobby("do_dishes")
> #optional
> interfaces/frobby.py:56: command = ['frobby'] + action.split()
> interfaces/frobby.py:96: sage: decom =
> frobby.irreducible_decomposition(id) #optional
> interfaces/frobby.py:109: ... decom0 =
> frobby.irreducible_decomposition(id0) #optional
> interfaces/frobby.py:119: ... decom1 =
> frobby.irreducible_decomposition(id1) #optional
> interfaces/frobby.py:124: frobby_input =
> self._ideal_to_string(monomial_ideal)
> interfaces/frobby.py:125: frobby_output = self('irrdecom',
> input=frobby_input)
> interfaces/frobby.py:126: return self._parse_ideals(frobby_output,
> monomial_ideal.ring())
> interfaces/frobby.py:146: sage: parsed_ideals =
> frobby._parse_ideals(string, ring) #optional
> interfaces/frobby.py:172: sage: parsed_matrix =
> frobby._parse_4ti2_matrix(string) #optional
> interfaces/frobby.py:179: sage:
> frobby._parse_4ti2_matrix(string) #optional
> interfaces/frobby.py:219: sage: frobby._ideal_to_string(id) ==
> "2 3\n2 0 0\n1 1 1\n" #optional
> interfaces/frobby.py:249: sage:
> frobby._monomial_to_string(monomial) == '2 0 1\n' #optional
> interfaces/frobby.py:266:frobby = Frobby()
> interfaces/all.py:3:from frobby import frobby
> }}}
> Once done, one should be able to test them with
> {{{
> sage -t -only_optional=frobby frobby.py
> }}}
>
> For positive review, these tests should also all actually pass!
New description:
These tests should all be marked {{{# optional - frobby}}}, but none of
them are:
{{{
sage: search_src('frobby')
misc/citation.pyx:26:systems['Frobby'] = ['sage.interfaces.frobby']
interfaces/frobby.py:18: The official source for Frobby is
\url{http://www.broune.com/frobby},
interfaces/frobby.py:42: sage: frobby("analyze",
input="vars x,y,z;[x^2,x*y];", #optional
interfaces/frobby.py:46: We get an exception if frobby reports
an error.
interfaces/frobby.py:47: sage: frobby("do_dishes")
#optional
interfaces/frobby.py:56: command = ['frobby'] + action.split()
interfaces/frobby.py:96: sage: decom =
frobby.irreducible_decomposition(id) #optional
interfaces/frobby.py:109: ... decom0 =
frobby.irreducible_decomposition(id0) #optional
interfaces/frobby.py:119: ... decom1 =
frobby.irreducible_decomposition(id1) #optional
interfaces/frobby.py:124: frobby_input =
self._ideal_to_string(monomial_ideal)
interfaces/frobby.py:125: frobby_output = self('irrdecom',
input=frobby_input)
interfaces/frobby.py:126: return self._parse_ideals(frobby_output,
monomial_ideal.ring())
interfaces/frobby.py:146: sage: parsed_ideals =
frobby._parse_ideals(string, ring) #optional
interfaces/frobby.py:172: sage: parsed_matrix =
frobby._parse_4ti2_matrix(string) #optional
interfaces/frobby.py:179: sage:
frobby._parse_4ti2_matrix(string) #optional
interfaces/frobby.py:219: sage: frobby._ideal_to_string(id) ==
"2 3\n2 0 0\n1 1 1\n" #optional
interfaces/frobby.py:249: sage:
frobby._monomial_to_string(monomial) == '2 0 1\n' #optional
interfaces/frobby.py:266:frobby = Frobby()
interfaces/all.py:3:from frobby import frobby
}}}
Once done, one should be able to test them with
{{{
sage -t -only_optional=frobby frobby.py
}}}
Fixed by #14841.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/12338#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
