#15044: Meredith Graph constructor
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-5.12
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: | Reviewers: Rob Beezer
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/ncohen/meredith_graph | 90b4aa8eb215dd3567fefff2d09576f555c5c370
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooo Rob !!!
> All fine on your side. I spent *forever* trying to make it a "tracking"
branch on my side. Maybe details on sage-git later today.
Hmmmm... I don't even know what that means yet :-P
> All good for a positive review.
Thanks !!
> I added a commit hash in the "Commit" field - I hope that is right.
Hmmmmm.. Some time ago I think I saw a discussion on sage-git that I
didn't understand at that time about whether we should use branches or
commits references. And I think that we should use branches instead, for
the following reason :
* This Meredith patch was uploaded yesterday, when the git version of Sage
was still version 5.11.rc0
* I then updated my version of sage-git to 5.12 with a git pull
* I now want to write a patch #15049 that is based upon this patch
The point now, is that this patch's commit was created before 5.12. Hence
if I want to write #15049 atop this patch, I can't be above 5.12 too. What
I could do, however, is rebase this patch atop 5.12, hence updating the
u/ncohen/meredith branch, then write #15049 on this new meredith branch
which is above 5.12.
The problem is that the hash of a commit changes when you rebase it. Or at
least I found no way to avoid that O_o
Sooooooo hoping that it is not a problem, I will try to rebase this patch
above 5.12 (and there should not be any conflict), update the commit
message to match the new version of the meredith commit, then base #15049
atop of that.
I hope all of that was clear `:-P`
Have fuuuuuuuuuun ! And thank you again `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15044#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
