#12882: Allows a generalized Cartan matrix as input for Dynkin diagrams
-------------------------------------------------+-------------------------
Reporter: stumpc5 | Owner: sage-
Type: enhancement | combinat
Priority: major | Status:
Component: combinatorics | needs_work
Keywords: Weyl group, Dynkin diagram, | Milestone: sage-5.12
Cartan matrix, days49 | Resolution:
Authors: Christian Stump, Travis | Merged in:
Scrimshaw | Reviewers: Ben
Report Upstream: N/A | Salisbury
Branch: | Work issues:
Dependencies: #14137 #14516 | Commit:
| Stopgaps:
-------------------------------------------------+-------------------------
Comment (by tscrim):
Okay, I've made the offending test return a sorted list. However this
should be overkill since `index_set` just makes the call to `vertices`,
which returns a sorted list, into a tuple (i.e. there doesn't seem to be a
set/dict being returned...). Here's the patches have applied on
`5.11.rc0`:
{{{
trac_14882-backtrack_longtime-dg.patch
trac_13589-categories-c3_under_control-nt.patch
trac_14507-tropical_semiring-ts.patch
trac_7983-major_index_and_other_tableau_fixes-dg.patch
trac_7983-review-ts.patch
trac_8386_really_just_moving-fc.patch
trac_8386_big_clean_fc.patch
trac_8386_assert_removal.patch
trac_14808-recoils_of_permutations-ts.patch
trac_10630-vector_partition-ap.patch
trac_14870-fix_int_mod_QQ-ts.patch
trac_14787-gyw_stats-bs.patch
trac_14787-pdf_fix-ts.patch
trac_14573-path_realizations-ts.patch
trac_11407-list_clone_improve-fh.patch
trac_14516-crystals_speedup-ts.patch
trac_12882-matrix_as_dynkin_diagram-ts.patch
}}}
So I'm confused about why we're getting different results, and slightly
worried.
Anyways, Ben could you do a quick re-review of the patch? Thanks.
For patchbot:
Apply: trac_12882-matrix_as_dynkin_diagram-ts.patch
--
Ticket URL: <http://trac.sagemath.org/ticket/12882#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
