#14806: Immutable graph backend
---------------------------------+----------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14805 | Stopgaps:
---------------------------------+----------------------------------
Comment (by azi):
Hello!
As promised I peaked at the code!! In general the patch looks good to me
with the exception of the above comments.
* Can we use xrange instead of range when we only iterate over something?
* Can we raise a ValeError in '''in_neighbors'' if u is not in the graph
as to be consistent with how out_degree works?
* In the function '''iterator_in_edges''' why do we need the call to iter
in the following line ?
{{{
for x in iter(self.iterator_out_edges(vertices, labels)):
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/14806#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
