#8392: Implement RSK for generalized permutations
-------------------------------------+-------------------------------------
Reporter: nborie | Owner: tscrim
Type: enhancement | Status: closed
Priority: major | Milestone: sage-5.11
Component: combinatorics | Resolution: fixed
Keywords: permutation, | Merged in: sage-5.11.beta0
check, days38, days45 | Reviewers: Jeff Ferreira, Darij
Authors: Travis Scrimshaw | Grinberg
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #6495, #13605, | Stopgaps:
#8703, #14459, #14319, #14302 |
-------------------------------------+-------------------------------------
Comment (by saliola):
Thanks for writing this patch. I support the proposed clean up of the
code, but I want to raise an objection to choices in the user interface:
- I don't think that it is useful to deprecate the method
{{{robinson_schensted}}}:
{{{
DeprecationWarning: p.robinson_schensted() is deprecated. Use instead
RSK(p)
}}}
Telling users to use the RSK function instead of a method is not in the
spirit of object-oriented programming. More importantly, it is totally
unnecessary to deprecate the method.
- Also, I disagree with importing {{{RSK, RSK_inverse,
RobinsonSchenstedKnuth, RobinsonSchenstedKnuth_inverse}}} into the global
namespace when one object could easily handle all of these.
- Perhaps these names should not be capitalized since they are python
functions and not classes. See the
[http://www.sagemath.org/doc/developer/conventions.html?highlight=camelcase
#python-coding-conventions developers guide].
--
Ticket URL: <http://trac.sagemath.org/ticket/8392#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
