#12183: absolute and relative norm functions for number field elements
-------------------------+-------------------------------------------------
       Reporter:         |        Owner:  davidloeffler
  MvanBeek               |       Status:  positive_review
           Type:         |    Milestone:  sage-5.12
  enhancement            |   Resolution:
       Priority:  major  |    Merged in:
      Component:         |    Reviewers:  Michiel Kosters, Angelos
  number fields          |  Koutsianas
       Keywords:         |  Work issues:
        Authors:         |       Commit:
  Monique van Beek       |     Stopgaps:
Report Upstream:  N/A    |
         Branch:         |
   Dependencies:         |
-------------------------+-------------------------------------------------
Changes (by davidloeffler):

 * status:  needs_work => positive_review


Old description:

> Although number_field_element.pyx has a norm method, it does not have
> absolute_norm() and relative_norm(). This would be a useful shorthand to
> have.
>
> Apply [attachment:12183.3.patch].

New description:

 Although number_field_element.pyx has a norm method, it does not have
 absolute_norm() and relative_norm(). This would be a useful shorthand to
 have.

 Apply [attachment:12183_5.patch].

--

Comment:

 The patch doesn't actually need rebasing. The problem here is that Michiel
 made a new patch [attachment:12183_5.patch], and Angelos gave a positive
 review to that patch, but the ticket description still said "apply
 [attachment:12183.3.patch]". I have corrected the ticket description, and
 verified that the latest patch does have a proper commit message and
 applies without fuzz to the latest 5.12.beta2.

--
Ticket URL: <http://trac.sagemath.org/ticket/12183#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to