#14498: trees and binary trees
----------------------------------------------+----------------------------
       Reporter:  elixyre                     |        Owner:  sage-
           Type:  enhancement                 |  combinat
       Priority:  major                       |       Status:  needs_review
      Component:  combinatorics               |    Milestone:  sage-5.12
       Keywords:  trees, binary trees, latex  |   Resolution:
        Authors:  Jean-Baptiste Priez         |    Merged in:
Report Upstream:  N/A                         |    Reviewers:
         Branch:                              |  Work issues:
   Dependencies:  #8703, #14784               |       Commit:
                                              |     Stopgaps:
----------------------------------------------+----------------------------

Comment (by chapoton):

 Have you made your patch using "hg export" or in some other strange way
 (by hand) ?

 The standard process is to use
 {{{
 hg export tip > $HOME/trac_xxx.patch
 }}}
 to export the patch as a file, after making sure your patch is the top
 applied patch. Then upload the resulting file to trac.

 Any other way is bound to have strange results..

 It looks like you have concatenated several patches by hand maybe ? You
 must use hg qfold to do that.

 ---

 Quick comments on the code:

 it is a bad idea to use

 {{{
 q = SymbolicRing().var('q')
 }}}

 to have a polynomial variable. Much better is
 {{{
 q = polygen(QQ, 'x')
 }}}
 In the same hook-length function, you should write "There are 20
 permutations"

--
Ticket URL: <http://trac.sagemath.org/ticket/14498#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to