#13615: Extend elliptic curve isogenies to arbitrary prime degrees
-------------------------------------+-------------------------------------
Reporter: cremona | Owner: John Cremona
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: elliptic curves | Resolution:
Keywords: isogenies, sd51 | Merged in:
Authors: Kimi Tsukazaki, | Reviewers: John Cremona, Jenny
John Cremona | Cooley, Samuele Anni
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by defeo):
Nice work! I'm reviewing the patch, but of all the new functions in
`isogeny_genus_0.py` the only one I could understand is
`isogenies_prime_degree_general()`.
I can't seem to find Kimi's thesis online. Could you put it somewhere, so
that we can compare with the theory? Also, it would be nice if the
docstrings of the new functions pointed to the corresponding sections in
Kimi's thesis (assuming that's the only source).
Here's more thoughts:
- It seems weird that `isogenies_prime_degree_general()` is in
`isogeny_genus_0.py`. Why is it not in `ell_curve_isogeny.py()` or in some
other ''generic'' place?
- `least_semi_primitive()` is a purely internal function, I would rename
it to `_least_semi_primitive()`.
- In the docstring of `least_semi_primitive()`, the `{1,-1}` should be
`\{1,-1\}` (although this is not very important if you follow my previous
suggestion).
--
Ticket URL: <http://trac.sagemath.org/ticket/13615#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
