#11772: improving error reporting of random_matrix, and bug fixing
----------------------------------+--------------------------
       Reporter:  dimpase         |        Owner:  jason, was
           Type:  enhancement     |       Status:  needs_work
       Priority:  major           |    Milestone:  sage-5.12
      Component:  linear algebra  |   Resolution:
       Keywords:                  |    Merged in:
        Authors:                  |    Reviewers:  Rob Beezer
Report Upstream:  N/A             |  Work issues:
         Branch:                  |       Commit:
   Dependencies:                  |     Stopgaps:
----------------------------------+--------------------------
Description changed by rbeezer:

Old description:

> The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
> cryptic.
> It should be easy to check that the rank is greater than min(nrows,ncols)
> and throw a ValueError with a meaningful message.
>
> A patch, which also fixes a similar small fly in random_subspaces_matrix,
> is attached.
> The cumulative patch incorporates more doctests, the fix for rank==1
> problem described in the comments, and puts a cup on the number of
> iterations in various while loops, so that they fail meaningfully.
>
> '''Apply''':
>   1.  [attachment:trac_11772.2.patch]

New description:

 The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
 cryptic.
 It should be easy to check that the rank is greater than min(nrows,ncols)
 and throw a ValueError with a meaningful message.

 A patch, which also fixes a similar small fly in random_subspaces_matrix,
 is attached.
 The cumulative patch incorporates more doctests, the fix for rank==1
 problem described in the comments, and puts a cup on the number of
 iterations in various while loops, so that they fail meaningfully.

 '''Apply''':
   1.  [attachment:trac_11772.3.patch]

--

--
Ticket URL: <http://trac.sagemath.org/ticket/11772#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to