#14819: Root system plot improvements: arrow tips, fundamental polygon, ...
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
nthiery | Status: positive_review
Type: | Milestone: sage-5.12
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Frédéric Chapoton, Travis
combinatorics | Scrimshaw
Keywords: | Work issues:
Authors: | Commit:
Nicolas M. Thiéry | Stopgaps:
Report Upstream: N/A |
Branch: |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
Comment:
Now I get (with `sage-5.11.rc0` in the combinat queue):
{{{
sage -t root_lattice_realizations.py
[450 tests, 49.10 s]
sage -t plot.py
**********************************************************************
File "plot.py", line 1091, in sage.combinat.root_system.plot.PlotOptions.?
Failed example:
sorted(p[0].options().items())
Expected:
[('alpha', 0.500000000000000), ('legend_color', None),
('legend_label', None), ('rgbcolor', 'green'), ('thickness', 4),
('zorder', 1)]
Got:
[('alpha', 0.500000000000000), ('legend_label', None), ('rgbcolor',
'green'), ('thickness', 4), ('zorder', 1)]
**********************************************************************
1 item had failures:
1 of 33 in sage.combinat.root_system.plot.PlotOptions.?
[252 tests, 1 failure, 74.20 s]
----------------------------------------------------------------------
sage -t plot.py # 1 doctest failed
----------------------------------------------------------------------
}}}
So it's probable that something changed between `5.11.rc0` and
`5.12.beta3` which is not reflected in the combinat queue. I'm going to
set this to positive review and build `5.12.beta3` today and report back
if I get a doctest failure.
--
Ticket URL: <http://trac.sagemath.org/ticket/14819#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
