#14749: check whether gprc.expect exists
-------------------------------------+-------------------------------------
Reporter: felixs | Owner: Felix Salfelder
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-5.12
Component: doctest coverage | Resolution:
Keywords: gp, expect, | Merged in:
configuration | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/felixs/gprc | f028367e6a6ee5a726b917dd3ed041e2fd476f7b
Dependencies: #14750 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by felixs):
* status: needs_work => needs_review
* commit: 33ca380a373c0cbc10f00ea4e5c6ad4dd4aad6fc =>
f028367e6a6ee5a726b917dd3ed041e2fd476f7b
Comment:
Replying to [comment:4 jdemeyer]:
> 1) Why does this depend on #14750?
#14750 provides `SAGE_ETC`. This way, the test does not need to be edited
after #14750.
> 2) The comment {{{We illustrate objects that wrap GP objects (gp is the
PARI interpreter)::}}} has absolutely nothing to do with the test you
added, so the comment should be fixed.
done.
> 3) It is better to use `os.path.isfile()` instead of `os.path.exists()`
since it's a more specific test.
Why should it not be a symlink? It's just a big pain if it does not exist
at all.
> 4) Please make it clear whether the patch or the git branch should be
merged. If you want the patch to be merged, it should be in Mercurial
format.
This is now two commits on top of #14750, and can be merged after #14750.
thanks
--
Ticket URL: <http://trac.sagemath.org/ticket/14749#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
