#14888: Make FiniteField_pari_ffelt the default for generic finite fields
-------------------------------------------+-------------------------------
       Reporter:  pbruin                   |        Owner:  cpernet
           Type:  enhancement              |       Status:  needs_work
       Priority:  major                    |    Milestone:  sage-5.12
      Component:  finite rings             |   Resolution:
       Keywords:  FiniteField performance  |    Merged in:
        Authors:  Peter Bruin              |    Reviewers:  Jean-Pierre
Report Upstream:  N/A                      |  Flori
         Branch:                           |  Work issues:
   Dependencies:  #12142                   |       Commit:
                                           |     Stopgaps:
-------------------------------------------+-------------------------------
Changes (by jdemeyer):

 * status:  positive_review => needs_work


Comment:

 Doctest failures on 32-bit systems:
 {{{
 sage -t --long devel/sage/sage/graphs/generic_graph.py
 **********************************************************************
 File "devel/sage/sage/graphs/generic_graph.py", line 14898, in
 sage.graphs.generic_graph.GenericGraph.plot
 Failed example:
     H = S.hecke_matrix(2)
 Exception raised:
     Traceback (most recent call last):
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/doctest/forker.py", line 479, in _run
         self.execute(example, compiled, test.globs)
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/doctest/forker.py", line 838, in execute
         exec compiled in globs
       File "<doctest sage.graphs.generic_graph.GenericGraph.plot[78]>",
 line 1, in <module>
         H = S.hecke_matrix(Integer(2))
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/modular/ssmod/ssmod.py", line 1042, in hecke_matrix
         SS, II = self.supersingular_points()
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/modular/ssmod/ssmod.py", line 906, in
 supersingular_points
         neighbors = Phi_polys(2,X,ss_points[pos]).roots()
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/modular/ssmod/ssmod.py", line 206, in Phi_polys
         return x.parent()([j_pow[3] - 162000*j_pow[2] +
 8748000000*j_pow[1] -
       File "element.pyx", line 1701, in
 sage.structure.element.RingElement.__mul__
 (sage/structure/element.c:14531)
       File "coerce.pyx", line 803, in
 sage.structure.coerce.CoercionModel_cache_maps.bin_op
 (sage/structure/coerce.c:7330)
       File "coerce.pyx", line 917, in
 sage.structure.coerce.CoercionModel_cache_maps.canonical_coercion
 (sage/structure/coerce.c:8529)
       File "coerce_maps.pyx", line 82, in
 sage.structure.coerce_maps.DefaultConvertMap_unique._call_
 (sage/structure/coerce_maps.c:3856)
       File "coerce_maps.pyx", line 77, in
 sage.structure.coerce_maps.DefaultConvertMap_unique._call_
 (sage/structure/coerce_maps.c:3757)
       File
 
"/var/lib/buildbot/build/sage/arando-1/arando_full/build/sage-5.12.beta4/local/lib/python2.7
 /site-packages/sage/rings/finite_rings/finite_field_pari_ffelt.py", line
 501, in _element_constructor_
         return self.element_class(self, x)
       File "element_pari_ffelt.pyx", line 145, in
 
sage.rings.finite_rings.element_pari_ffelt.FiniteFieldElement_pari_ffelt.__init__
 (sage/rings/finite_rings/element_pari_ffelt.c:2975)
       File "element_pari_ffelt.pyx", line 206, in
 
sage.rings.finite_rings.element_pari_ffelt.FiniteFieldElement_pari_ffelt.construct_from
 (sage/rings/finite_rings/element_pari_ffelt.c:3341)
     OverflowError: Python int too large to convert to C long
 **********************************************************************
 }}}
 (the same error occurs in other places)

 {{{
 sage -t --long devel/sage/sage/groups/generic.py
 **********************************************************************
 File "devel/sage/sage/groups/generic.py", line 422, in
 sage.groups.generic.bsgs
 Failed example:
     P=E.lift_x(a); P
 Expected:
     (a : 9*a^4 + 22*a^3 + 23*a^2 + 30 : 1)
 Got:
     (a : 28*a^4 + 15*a^3 + 14*a^2 + 7 : 1)
 **********************************************************************
 File "devel/sage/sage/groups/generic.py", line 851, in
 sage.groups.generic.discrete_log_lambda
 Failed example:
     P=E.lift_x(a); P
 Expected:
     (a : 28*a^4 + 15*a^3 + 14*a^2 + 7 : 1)
 Got:
     (a : 9*a^4 + 22*a^3 + 23*a^2 + 30 : 1)
 **********************************************************************
 }}}
 (due to a different square root being returned)

--
Ticket URL: <http://trac.sagemath.org/ticket/14888#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to