#6667: bug in newton_polygon() for p-adic polynomials
-------------------------------------+----------------------------
Reporter: AlexGhitza | Owner: roed
Type: defect | Status: needs_review
Priority: major | Milestone:
Component: padics | Resolution:
Keywords: newton polygon | Merged in:
Authors: Frédéric Chapoton | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14826 | Stopgaps: #12701
-------------------------------------+----------------------------
Comment (by caruso):
Replying to [comment:10 chapoton]:
> here is a review patch, with only minor changes to your code
Thanks!
> in my opinion, it would be good to add examples for the two other raise
statements.
Actually, I believe that they can't occur but it seemed to be really safer
to check them anyway. (I added a comment in the code to mention that.)
I also corrected another bug: the valuation of the coefficients are not
the values in the list `self._valadded` but these values augmented by
`self._valbase` (as far as I understand David's code). As a consequence,
the computation was wrong when the gcd of all coefficients was not 1. I
added a doctest to check this issue.
Apply only [attachment:trac_6667_caruso_revised.patch] (it includes your
review).
--
Ticket URL: <http://trac.sagemath.org/ticket/6667#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
