#3932: [with patch, needs review] generate size n trees in linear time
--------------------------+-------------------------------------------------
Reporter: jason | Owner: rlm
Type: enhancement | Status: reopened
Priority: major | Milestone: sage-4.0
Component: graph theory | Resolution:
Keywords: |
--------------------------+-------------------------------------------------
Comment(by rlm):
1. Please change the `cdef void` functions to `cdef int` so that
exceptions can be passed through them.
2. You can add a `cdef object G` to `__next__`. Since that's the iteration
step, the speed might make a sliver of difference (maybe not).
3. `fixit = True` should probably be `fixit = 1` since `True` would
inherit Python noise. You also don't need `if fixit == 1:`, just `if
fixit:`
4. This is a great patch. I'll post another patch later today which will
tie this into the main tree generator, and we'll see what kind of speedups
you get.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3932#comment:9>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
