#10126: Fix error handing in Matrix_rational_dense._invert_pari()
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner: jason, was
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-
Component: linear algebra | duplicate/invalid/wontfix
Keywords: pari sig_on | Resolution:
interrupt exception | Merged in:
Authors: Jeroen Demeyer | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #14894 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Jeroen Demeyer', 'oldvalue': u'Peter Bruin'}):
* status: needs_review => positive_review
* reviewer: => Peter Bruin
* author: Peter Bruin => Jeroen Demeyer
Old description:
> From {{{sage/matrix/matrix_rational_dense.pyx}}}:
>
> {{{
> # unfortunately I can't get signal handling to be good enough
> # to properly catch error (and clean up) when trying to
> # compute inverse, so we have to compute rank. This does add
> # time... (!) :-(
> }}}
>
> The attached patch should fix this. It is based on the new PARI error
> handling macros from #14894, but it is possible that something similar
> works with the current error handling code.
>
> Apply: [attachment:trac_10126-invert_rational_matrix_pari.patch]
New description:
From {{{sage/matrix/matrix_rational_dense.pyx}}}:
{{{
# unfortunately I can't get signal handling to be good enough
# to properly catch error (and clean up) when trying to
# compute inverse, so we have to compute rank. This does add
# time... (!) :-(
}}}
This is fixed by #15124.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/10126#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
