#15127: cleanup of matchpoly.pyx
-------------------------------------+-------------------------
Reporter: chapoton | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: sage-5.12
Component: graph theory | Resolution:
Keywords: matchpoly | Merged in:
Authors: Frédéric Chapoton | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-------------------------------------+-------------------------
Comment (by ncohen):
Yoooooooooooooooo !!
>
http://patchbot.sagemath.org/log/12186/Fedora/19/x86_64/3.10.4-300.fc19.x86_64/desktop/2013-08-22%2001:08:17%20+0100?short
Oh.
> I would rather think that #12186 is not the cause of the problem, but
something inside matchpoly.pyx is the cause.
>
> And yes, I worked on that in the hope that the next time that
matchpoly.pyx is failing in some seemingly unrelated ticket, one would get
better error messages.
OkayOkay...
> Then I started putting things into pep8, for no special reason.
Okayyyy...
> Concerning the use of [1..5], I do not like it, because it only works
through the preparser, which transform it into ellipsis_range. But well..
Well. I don't know what this `ellipsis_range` thing is, but this `[1..5]`
is pretty clear when it is written, and I use it when I want to show code
in such a way that it can be easily understood. `range(5)` is something
that you have to explain.
> What should we do with this ticket:
Well, I was about to give it a positive review, so you tell me `^^;`
> * close it as invalid ?
> * replace it by something simpler, just moving the import a few lines
down in the tests ?
> * or by something just trying to get better info in case a failing test
in the "trees" ?
Well. Basically this patch does nothing but cosmetic changes. Why don't we
just merge it ? It doesn't do anything bad.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15127#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
