#11409: Remove old notebook files
----------------------------------+----------------------------
Reporter: jdemeyer | Owner: jdemeyer
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: notebook | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #13794, #14330 | Stopgaps:
----------------------------------+----------------------------
Old description:
> The old Sage notebook (as part of the Sage library) has been superseded
> by the sagenb spkg. The following files are from the old notebook and
> should be removed:
> * {{{$SAGE_ROOT/devel/sage/sage/server/introspect.py}}}
> * {{{$SAGE_ROOT/devel/sage/sage/server/notebook/*}}}
> * {{{$SAGE_ROOT/devel/sage/sage/server/simple/*}}}
>
> The following files are duplicated in sagenb but contain some
> functionality which is not specific to the notebook. At the moment no
> effort is made to dis-entangle these (but I have made them more uniform)
> * {{{$SAGE_ROOT/devel/sage/sage/server/misc.py}}}
> * {{{$SAGE_ROOT/devel/sage/sage/server/support.py}}}
>
> ----
>
> '''Apply''':
> 1. {{{cd sage/server && hg remove introspect.py notebook simple && hg
> commit -m "Trac #11409: Remove old notebook files"}}} # I prefer this
> shell command to a patch because there are no chances of a merge conflict
> 2. [attachment:trac_11409-rebased.patch]
>
> -----
>
> After applying the patches, running sdist, and then make from scratch, I
> get the following results:
>
> {{{
> $ cd $SAGE_ROOT
> $ grep -e 'server.simple' -e 'server.notebook' -e 'server.introspect' -R
> .
> Binary file ./devel/sage/.hg/store/data/doc/en/reference/notebook.rst.i
> matches
> Binary file ./devel/sage/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
> Binary file ./devel/sage/.hg/store/00manifest.d matches
> Binary file ./devel/sage-
> main/.hg/store/data/doc/en/reference/notebook.rst.i matches
> Binary file ./devel/sage-main/.hg/store/data/_m_a_n_i_f_e_s_t.in.i
> matches
> Binary file ./devel/sage-main/.hg/store/00manifest.d matches
> ./local/share/texmf/tex/generic/sagetex/remote-sagetex.dtx:% in
> \texttt{sage/server/simple/twist.py}.
> }}}
>
> This proves that the deleted files are no longer referenced (expect for a
> comment in SageTeX, this has been reported to Dan Drake).
>
> ----
>
> See also #9237, #9552.
New description:
The old Sage notebook (as part of the Sage library) has been superseded by
the sagenb spkg. The following files are from the old notebook and should
be removed:
* {{{$SAGE_ROOT/devel/sage/sage/server/introspect.py}}}
* {{{$SAGE_ROOT/devel/sage/sage/server/notebook/*}}}
* {{{$SAGE_ROOT/devel/sage/sage/server/simple/*}}}
The following files are duplicated in sagenb but contain some
functionality which is not specific to the notebook. At the moment no
effort is made to dis-entangle these (but I have made them more uniform)
* {{{$SAGE_ROOT/devel/sage/sage/server/misc.py}}}
* {{{$SAGE_ROOT/devel/sage/sage/server/support.py}}}
----
'''Apply''':
1. {{{cd sage/server && hg remove introspect.py notebook simple && hg
commit -m "Trac #11409: Remove old notebook files"}}} # I prefer this
shell command to a patch because there are no chances of a merge conflict
2. [attachment:trac_11409-rebased-v2.patch]
-----
After applying the patches, running sdist, and then make from scratch, I
get the following results:
{{{
$ cd $SAGE_ROOT
$ grep -e 'server.simple' -e 'server.notebook' -e 'server.introspect' -R .
Binary file ./devel/sage/.hg/store/data/doc/en/reference/notebook.rst.i
matches
Binary file ./devel/sage/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage/.hg/store/00manifest.d matches
Binary file ./devel/sage-
main/.hg/store/data/doc/en/reference/notebook.rst.i matches
Binary file ./devel/sage-main/.hg/store/data/_m_a_n_i_f_e_s_t.in.i matches
Binary file ./devel/sage-main/.hg/store/00manifest.d matches
./local/share/texmf/tex/generic/sagetex/remote-sagetex.dtx:% in
\texttt{sage/server/simple/twist.py}.
}}}
This proves that the deleted files are no longer referenced (expect for a
comment in SageTeX, this has been reported to Dan Drake).
----
See also #9237, #9552.
--
Comment (by chapoton):
I have rebased the patch on 5.12.beta4
I had also to put back the import of alarm and cancel_alarm in
server/misc.py
for the bot: apply only trac_11409-rebased-v2.patch
--
Ticket URL: <http://trac.sagemath.org/ticket/11409#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
