#15168: Plots not shown in the notebook
--------------------------------+----------------------------
Reporter: novoselt | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-5.12
Component: notebook | Resolution:
Keywords: plot | Merged in:
Authors: Volker Braun | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
--------------------------------+----------------------------
Comment (by ppurka):
A couple of comments regarding the patch
1. There are lots of trailing whitespace :)
2. Can you format `#14466` using the `:trac:` format
{{{
265 In #14466 we override IPython's special printing of
``type`` objects
}}}
3. In `set_display`, the `INPUT` should mention the default input.
{{{
285 - ``mode`` -- string. One of ``simple``, ``ascii_art``, or
``typeset``.
- to -
285 - ``mode`` -- string (default: ``simple``). One of
``simple``, ``ascii_art``, or ``typeset``.
}}}
4. In `set_display`, the default keyword value should be `simple` in
keeping with the default `mode="simple"`.
{{{
279 def set_display(self, mode='ascii_art'):
}}}
5. The method `try_format_graphics` does not return a boolean, contrary to
what its documentation says. The method seems to work because `if None`
fails when the display is not graphics.
6. Should we remove `pretty_print_default` from the global namespace? I am
referring to this comment:
{{{
2447 This function is pretty useless without the notebook, it
shoudn't
2448 be in the global namespace.
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/15168#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
