#15029: Implement similarity classes over principal ideal local rings of length 
two
-------------------------------------------------+-------------------------
       Reporter:  amri                           |        Owner:  amri
           Type:  enhancement                    |       Status:
       Priority:  major                          |  needs_review
      Component:  combinatorics                  |    Milestone:  sage-5.12
       Keywords:  similarity classs, matrices,   |   Resolution:
  local rings                                    |    Merged in:
        Authors:  Amritanshu Prasad              |    Reviewers:  Travis
Report Upstream:  N/A                            |  Scrimshaw
         Branch:                                 |  Work issues:
   Dependencies:  #14907                         |       Commit:
                                                 |     Stopgaps:
-------------------------------------------------+-------------------------

Old description:

> In the paper Similarity of matrices over local rings of length two
> [http://arxiv.org/abs/1212.6157], the similarity classes of n x n
> matrices with entries in a principal ideal local ring of length two are
> computed for n = 2, 3, 4. These calculations are being implemented in
> sage.

New description:

 In the paper Similarity of matrices over local rings of length two
 [http://arxiv.org/abs/1212.6157], the similarity classes of n x n matrices
 with entries in a principal ideal local ring of length two are computed
 for n = 2, 3, 4. These calculations are being implemented in sage.

 Apply:

 * [attachment:trac_15029-additions-similarity_class_type-ap.patch]
 * [attachment:trac_15029-review-ts.patch]

--

Comment (by tscrim):

 Hey Amri,

 Here's a review patch which does a few things:

 - Changes the name of the functions `*2` to `*_length_two` to be a little
 more explicit.
 - Adds `INPUT:` blocks to some of the functions.
 - Fixes some docstring mistakes I didn't catch the first time around in
 the whole file. I also converted it to use Sage's macro for finite fields
 `\GF{q}`.

 If you're happy with my changes, go ahead and set this to positive review.

 Thanks for your work on this,[[BR]]
 Travis

--
Ticket URL: <http://trac.sagemath.org/ticket/15029#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to