#13352: Running time improvement of the bitset_len method
---------------------------------+----------------------------
Reporter: dcoudert | Owner: jason
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: misc | Resolution:
Keywords: | Merged in:
Authors: David Coudert | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
---------------------------------+----------------------------
Comment (by ncohen):
I would also say that those 2 blocks
{{{
__attribute__ ((__target__ ("popcnt")))
static unsigned int builtin_popcount(unsigned int w){
return (sizeof(unsigned int)==4? __builtin_popcount(w) :
__builtin_popcountl(w));
}
}}}
are mistakes. Whatever happens, regardless of the architecture,
`__builtin_popcount` works on int type, and `__builtin_popcountl` works on
long types.
Also, perhaps you should credit Cristian RodrÃguez somewhere `:-P`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/13352#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
